Switched to using cfengine format instead of prettier for syntax-description.json#90
Merged
olehermanse merged 2 commits intocfengine:mainfrom Apr 24, 2026
Merged
Conversation
olehermanse
force-pushed
the
prettier
branch
2 times, most recently
from
6191799 to
912ce66
Compare
olehermanse
changed the title
…ription.json Prettier is by design not deterministic - in some cases it will split objects across multiple lines, while not doing the reverse, collapsing them if they fit on one line. From our perspective, deterministic formatting is more desirable. See: prettier/prettier#8324 https://github.com/prettier/prettier/blob/76efb33e75365aceab508b0504f0e6f5ba2dd540/docs/rationale.md#multi-line-objects Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
craigcomstock
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier is by design not deterministic - in some cases
it will split objects across multiple lines, while not doing the reverse,
collapsing them if they fit on one line.
From our perspective it is desirable to have deterministic formatting.
See:
prettier/prettier#8324
https://github.com/prettier/prettier/blob/76efb33e75365aceab508b0504f0e6f5ba2dd540/docs/rationale.md#multi-line-objects